Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update main README including template #2994

Merged
merged 1 commit into from
Aug 2, 2022
Merged

chore: Update main README including template #2994

merged 1 commit into from
Aug 2, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Aug 2, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022 •
edited
Loading

Codecov Report

Merging #2994 (12ce9d7) into master (fc447eb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2994      +/-   ##
==========================================
- Coverage   77.85%   77.84%   -0.02%     
==========================================
  Files         194      194              
  Lines       16560    16560              
==========================================
- Hits        12893    12891       -2     
- Misses       3667     3669       +2
Flag Coverage Δ
integrationtests 67.37% <ø> (-0.15%) ⬇️
unittests 59.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...east/infra/materialization/lambda/lambda_engine.py 93.75% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc447eb...12ce9d7. Read the comment docs.

felixwang9817
felixwang9817 approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@felixwang9817 felixwang9817 mentioned this pull request Aug 2, 2022
Merged
achals
achals approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 31be8e8 into feast-dev:master Aug 2, 2022
@adchia adchia deleted the fixReadMe branch August 5, 2022 20:43
adchia added a commit that referenced this pull request Aug 10, 2022
@adchia
chore: Update main README including template (#2994)
139f2c4 
Signed-off-by: Danny Chiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

@achals achals achals approved these changes

Assignees

@achals achals

@felixwang9817 felixwang9817

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adchia @codecov-commenter @feast-ci-bot @achals @felixwang9817